update
This commit is contained in:
@@ -11,7 +11,7 @@ func TestAuditFiltersFromRequest(t *testing.T) {
|
||||
t.Parallel()
|
||||
request := httptest.NewRequest(
|
||||
"GET",
|
||||
"/portal?audit_range=7d&audit_event=package_downloaded&audit_customer=Acme&audit_actor=taiadmin&audit_hostname=pve01&audit_package=sentinelone-linux&audit_ip=10.10.1.25&audit_details=install-rmm",
|
||||
"/portal?audit_range=7d&audit_event=package_downloaded&audit_customer=Acme&audit_user=taiadmin&audit_hostname=pve01&audit_package=sentinelone-linux&audit_ip=10.10.1.25&audit_details=install-rmm",
|
||||
nil,
|
||||
)
|
||||
filters := auditFiltersFromRequest(request)
|
||||
@@ -19,7 +19,7 @@ func TestAuditFiltersFromRequest(t *testing.T) {
|
||||
TimeRange: "7d",
|
||||
EventType: "package_downloaded",
|
||||
CustomerLabel: "Acme",
|
||||
Actor: "taiadmin",
|
||||
User: "taiadmin",
|
||||
Hostname: "pve01",
|
||||
PackageSlug: "sentinelone-linux",
|
||||
SourceIP: "10.10.1.25",
|
||||
@@ -38,6 +38,14 @@ func TestAuditFiltersDefaultToThirtyDays(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestAuditFiltersAcceptLegacyActorParameter(t *testing.T) {
|
||||
t.Parallel()
|
||||
request := httptest.NewRequest("GET", "/portal?audit_actor=legacy-user", nil)
|
||||
if filters := auditFiltersFromRequest(request); filters.User != "legacy-user" {
|
||||
t.Fatalf("user = %q, want legacy-user", filters.User)
|
||||
}
|
||||
}
|
||||
|
||||
func TestHasAuditQuery(t *testing.T) {
|
||||
t.Parallel()
|
||||
if !hasAuditQuery(httptest.NewRequest("GET", "/portal?audit_hostname=pve01", nil)) {
|
||||
@@ -54,7 +62,7 @@ func TestAuditQueryUsesPlaceholders(t *testing.T) {
|
||||
TimeRange: "all",
|
||||
EventType: "package_downloaded",
|
||||
CustomerLabel: "Acme",
|
||||
Actor: "taiadmin",
|
||||
User: "taiadmin",
|
||||
Hostname: "pve01",
|
||||
PackageSlug: "sentinelone-linux",
|
||||
SourceIP: "10.10.1.25",
|
||||
@@ -62,7 +70,7 @@ func TestAuditQueryUsesPlaceholders(t *testing.T) {
|
||||
}
|
||||
query, arguments := auditQuery(filters, 250)
|
||||
if strings.Contains(query, filters.CustomerLabel) ||
|
||||
strings.Contains(query, filters.Actor) ||
|
||||
strings.Contains(query, filters.User) ||
|
||||
strings.Contains(query, filters.Hostname) {
|
||||
t.Fatal("filter values must not be interpolated into the SQL query")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user